@fernandolapaz
Posted
Hi 👋, in case you want to take a look:
HTML / ACCESSIBILITY:
- The main content of every page (the card in this case) should be wrapped with the
<main>
tag.
- Regarding your comment, I leave you a code snipet wishing that it helps you:
<picture>
<source media="(min-width: 490px)" srcset="images/image-product-desktop.jpg">
<img src="images/image-product-mobile.jpg" alt="description">
</picture>
And this way you could give it an alt
text with a description, since it looks like a meaningful image.
- On the other hand, the icon is a decorative image and therefore needs an empty
alt
attribute to be ignored by a screen reader.
- 'Perfume' should be capitalized with CSS (using
text-transform: uppercase;
) and not in HTML. Some screen readers will read out uppercased text as individual letters.
CSS:
- You might consider using relative units like rem or em since they are better for scalable layouts. Something simple to start with would be to convert to rem (1 rem equals the font size of the root element, 16px by default).
- It might be good to get used to designing with the mobile first approach, which means designing for mobile first and then for desktop or any other device, as it is widely considered best practice.
I hope you find it useful, any questions do not hesitate : )
Regards,
Marked as helpful