@ratsagi
Posted
Hello there,
Congrats on completing this chellenge!
I have some suggestions to improve your solution:
- I noticed that you named main landmark as a product actually it is not correct because product card is a small part of it. this main landmark might have multiple of them so the correct way to use article or just a div therefore it should be h2 not h1 more details you can find here
- Vertical alignment doesn't work on mobile version because you have forgotten to provide the min-height: 100svh for the body.
Overall solution is good!
Hope you find this feedback helpful!
Good luck!
Marked as helpful
@hellcsaba
Posted
Hi Sagi,
Thank you very much for your feedback. I will take a look on my code and review it according to your suggestions.
Good luck too!