Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey @johansantana, some suggestions to improve you code:
-
The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.
-
This challenges requires you to use two images for different breakpoints. To properly achieve this, you want to use <picture> element.
Syntax:
<picture> <source media="(min-width: )" srcset=""> <img src="" alt=""> </picture>
Source:
https://www.w3schools.com/html/html_images_picture.asp
https://web.dev/learn/design/picture-element/
-
The name of the perfume, “Gabrielle Essence Eau De Parfum” is the most important content in your card. So it has to be wrapped in a <h1> Heading. If this was a larger challenge with more card in the same page, then an <h2> or <h3> heading would be the better choice.
-
The old price is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.
Happy Coding! 👻🎃
1@johansantanaPosted about 2 years ago@vcarames Appreciate the feedback!, i'm implementing those right away
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord