Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I would animate interactions and write with better semantics next time.
What challenges did you encounter, and how did you overcome them?Learning how and where to investigate when solving a problem
What specific areas of your project would you like help with?Any feedback will be truly appreciated.
Community feedback
- @mkborisPosted 3 months ago
Here are a few things to review
- To properly center the card use flexbox. add this on your
body
and remove the margins from the .card
display: flex; flex-direction: column; align-items: center; justify-content: center; min-height: 100vh;
- To handle responsive images effectively you can use the
picture
element. This allows you to specify different images for various screen sizes and resolutions. - It's best practice linking Google fonts directly in the HTML
head
section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times. - Media queries should be defined in
rem
not px - Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
- Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
Marked as helpful1@gonzzdevPosted 3 months ago@mkboris Awesome! thank you very much. Both articles are really good. Im already applying the changes 💪🏽
1 - To properly center the card use flexbox. add this on your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord