Responsive Product Preview Card

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="inner-outer"> with the main tag, <h2> with <h1> and <h3> with <p> to make the content/page accessible. click here for more on web-accessibility and semantic html

  Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  The body has a wrong background-color. Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

  to center ,inner-outer on the page using flexbox or grid instead of margin,

  • USING FLEXBOX: add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body

  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  • USING GRID: add min-height:100vh; display: grid place-items: center to the body

  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here

  For a responsive content give .inner-outer a fixed max-width value. max-width: 500px

  Replace the height in .preview with a padding value for all the sides and change the value of the height in the img/.perfume to 100%.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Ammar•80

  @xiAvalonPosted over 1 year ago

  @Hassiai Thanks for the feedback.

  1