Responsive Product Preview Card- CSS Grid & Flexbox

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Hello Yusuf,

  congrats on completing the challenge successfully! I'd have few suggestions regarding best practices:

  • You have used height: 450px; but in general try to avoid giving fixed heights or max-heights for text containing elements like you have for .container, even if it is in rem, because it can cause issues later on (with changing dynamic data, when the user changes font-sizes, or even browser rendering issues etc.). The container height should be determined by the height of its children elements.

  • Additionally I've noticed you have used px for the font-sizes (32px etc.) and other elements, but i'd suggest try to avoid using px as much as you can, instead try to use em or rem to improve accessibility. Here is a great resource on YT for clarifying all the differences between rem/em: https://www.youtube.com/watch?v=dHbYcAncAgQ

  Hope you find this feedback helpful!

  Marked as helpful

  1
• 

  Francisco Carrillo•5,540

  @frank-itachiPosted over 1 year ago

  Hello there 👋. Congratulation for completing the challenge👍!

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.
  • The heading order is important in the html structure so try to always start your headings and/or titles with an <h1> tag and then you can increase by one if you need to use more heading in your html code.
  • Since the mobile design has a different image, you can use the <picture> tag that allows you to interchange the images depending of the viewport size. Red more about this awesome tag here.

  I hope you find it useful! 😄 Above all, you did a good job!

  Happy <coding /> 😎!

  Marked as helpful

  0

  ---

  

  yusuf akılevi•220

  @YusufAkileviPosted over 1 year ago

  @frank-itachi thanks for the feedback 😀

  0
• 

  Alberth Ruado•650

  @alberthgrandePosted over 1 year ago

  I recommend that you use Github Desktop instead, since you don't have to type the git command and it is easy to use.

  Here is where you can download it: https://desktop.github.com/

  1