Product preview card component (HTML + CSS)

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • For this challenge, You had two images, one for the product on desktop and another for mobile devices. One solution could have been to implement the <picture> element. This element is used to provide multiple sources or versions of an image, allowing the browser to choose the most appropriate one based on the user's device and screen size.

    You can read more about this here 📘.

  CSS 🎨:

  • Use min-height instead of height: 97vh. Setting the height to 97vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  1

  ---

  

  Tim Avidon•300

  @timavidonPosted about 1 year ago

  @MelvinAguilar Hi, I appreciate the the time you took to write me some feedback and suggestions. thank you!

  0