Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component (HTML + CSS)

Tim Avidonβ€’ 300

@timavidon

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I'm open to feedback.

thanks.

Community feedback

@MelvinAguilar

Posted

Hello there πŸ‘‹. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

HTML 🏷️:

  • For this challenge, You had two images, one for the product on desktop and another for mobile devices. One solution could have been to implement the <picture> element. This element is used to provide multiple sources or versions of an image, allowing the browser to choose the most appropriate one based on the user's device and screen size.

    You can read more about this here πŸ“˜.

CSS 🎨:

  • Use min-height instead of height: 97vh. Setting the height to 97vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

I hope you find it useful! πŸ˜„

Happy coding!

Marked as helpful

1

Tim Avidonβ€’ 300

@timavidon

Posted

@MelvinAguilar Hi, I appreciate the the time you took to write me some feedback and suggestions. thank you!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord