Submitted almost 2 years ago

Responsive product preview card component using CSS flexbox

Kelly CHI• 210

@KellyCHI22

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

Product preview card component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

Hi there, thanks for reviewing my code. After seeing a few solutions by other people, I found accessibility is a big topic to work on. Any suggestions or tips for starting to increase accessibility in all projects?

Community feedback

Aatypic• 490

@Aatypic

Posted almost 2 years ago

Hello and congratulations on your first solution, it's looking very good !

Concerning your question, I'm a newbie but I think on others challenges with more content would be easier to point out what can be improved accessibility wise.

-For the prices you could have a <span> with an .sr-only class explaining which one is, kind of like their class name. Other than that the texts are self explanatory.

-Another thing in the button you can achieve the same results without the <p> element and I don't think it's appropriate for it's content, you already have the <img> and the <span>.

Anyway some minor stuff

Good luck ✌️

Marked as helpful

Kelly CHI• 210

@KellyCHI22

Posted almost 2 years ago

Hello @Aatypic, thank you for your feedback!

About your suggestions:

I didn't know about .sr-only, thank you! I will find more info on that.
At first I was thinking that I couldn't set both display: flex and display: block on the button at the same time, but it turned out I can! This way I can deleted the <p> element. Thank you!

Good luck for your learning too :)

Adriano• 34,090

@AdrianoEscarabote

Posted almost 2 years ago

Hi Kelly CHI, how are you?

I really liked the result of your project, but I have some tips that I think you will like:

1- We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

Example:

native HTML5 reference elements:

<body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

<body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

Link to read more about: click here

2- Why it Matters

Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

Rule Description

It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

Link to read more about: click here

Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

The rest is great!!

Hope it helps...👍

Kelly CHI• 210

@KellyCHI22

Posted almost 2 years ago

Hello @AdrianoEscarabote, thank you for your feedback!

Concerning your suggestions:

All the content should be contained in a reference region

Yes, this is really important. I've changed the attribution area tag from div to footer.

Use rem over px

This is also for responsive issues. I should keep that in mind! I've changed most px units to rem or em in my project, thank you!

Thanks again for the feedback 👍

Raja Junaid Farooq• 390

@Raja-Junaid

Posted almost 2 years ago

Hi Kelly! I hope you are fine.

Congratulation on completing this challenge and also welcome to the front-end-mentor community. I really like your solution. I have some tips and tricks to improve your coding skills:

1- Use decent colors for attraction.

2- Keep your work as decent as possible when creating a webpage.

3- Keep your webpage neat and clean.

4- Use good-looking fonts.

5- Never forget to place comments in your code, it's beneficial to understand your code and what's going on.

✌️ I hope this helps you and happy coding!

Kelly CHI• 210

@KellyCHI22

Posted almost 2 years ago

Hello @Raja-Junaid, thank you for your feedback! I will keep those tips in mind :)

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord