Responsive Product preview card component
Design comparison
Solution retrospective
Thank you for checking out my solution. I have learned Sass but i have difficulty with importing different files. I have tried to some of my scss in another file but it ruined my card layout. I was wondering if anyone has tips to do this properly.? I would really appreciate it and it would be very helpful if you could give me a feedback. Thank you for your time ^.^
Community feedback
- @Finney06Posted over 1 year ago
Hello there 👋. Good job on completing the challenge !
Here are some suggestions regarding your code that may be of interest to you.
HTML 🏷️:
To clear the Accessibility report:
-
Wrap the page's whole main content in the
<main>tag. -
Use HTML5 semantic elements such as
<header>,<nav>,<main>,<aside>, and<footer>to define these sections. -
Use ARIA landmarks such as
<header role="banner">and<footer role="contentinfo">to provide additional information about the purpose of each section to assistive technologies.
Here is a web accessibility evaluation tool📕 to check your webpage for any remaining errors or warnings related to landmarks.
I hope you find it helpful!😏 Above all, the solution you submitted is 👌. 🎉Happy coding!
Marked as helpful0@JlovellealfechePosted over 1 year ago@Finney06 Thank you for the tips i just edited my solution now there is no more issues found. Have a lovely day :)
1 -
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord