Responsive Product Preview Card Component

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 9 months ago

  Hello @WestSopho!

  Your solution looks great!

  I have a couple of suggestions (about semantic HTML) for improvement:

  📌 First: Use <main> to wrap the main content instead of <div>.

  Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.

  📌 Second: Use <h1> for the main title instead of <p>.

  The tag <p> is meant for paragraphs. For titles, we have the HTML headings (the tags <h1> to <h6>).

  Here's a quick guide on how to use them:

  Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.

  • <h1> defines the most important heading.

  • <h6> defines the least important heading.

  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  0
• 

  Johnny Gérard•640

  @johnnygerardPosted 9 months ago

  Hello @WestSopho,

  Your Tailwind standalone CLI tailwindcss.exe should not be in your Git repository. In general, binary files should not be committed because they take a lot of space (37.4MB in your case). Only source code should be in your repository (except images which are usually fine).

  So, I recommend you add a .gitignore file with your file name as an entry:

  /tailwindcss.exe
  

  0
• 

  Craig•190

  @cchiversPosted 9 months ago

  Awesome Job. I just finished this project as well. I ended up using a display: flex for mine and changed the orientation depending on if I was mobile or desktop. The image also depending on orientation is set to width: 50% (desktop) or 100%(mobile).

  As I just finished this you can view my code on GitHub and see what I am talking about if I did not explain that well enough.

  0