Responsive Product preview card component

Community feedback

• 

  P

  Steven Stroud•11,910

  @StroudyPosted about 2 months ago

  Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…

  • This should be in lowercase <h2>PERFUME</h2> and styled in CSS with text-transform: uppercase;, Keeping text lowercase in HTML improves accessibility and SEO. Using text-transform: uppercase; in CSS separates content from style, ensuring screen readers interpret the text correctly.

  • Your heading elements <h2><h1>, Heading elements should be in sequentially-descending order (e.g., <h1>, <h2>, <h3>) to create a clear content structure, improving accessibility and SEO. Skipping levels or using them out of order can confuse screen readers, affect search engine rankings, and make your content harder to understand.

          <h2>PERFUME</h2>
          <h1>Gabrielle Essence Eau De Parfum</h1>
  

  • Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset

  • I think you can benefit from using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,

  • Height and Width should also be in rem and use max-width & min-height not just plain width or height.

  • For future project, You could download and host your own fonts using @font-face improves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. Place to get .woff2 fonts

  I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻

  Marked as helpful

  0

  ---

  

  Amanda Carpenedo•50

  @amanda-carpenedoPosted about 2 months ago

  Thank you @Stroudy! I started studying web development four months ago. I hope to learn a little every day. Thank you very much for your tips

  1

  

  P

  Steven Stroud•11,910

  @StroudyPosted about 2 months ago

  Hey @amanda-carpenedo, Your on the right track, Its not a race, Im learning to and I can only do a little bit every week but getting there 💪

  I hope this feedback is useful! Lets go!

  Marked as helpful

  0