Responsive product preview card

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @Lilee52, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  A better way to work this solution image, the product image is by using <picture> to wrap it on the html instead of using it as <img> or background-image (with the css). Using <picture> you wrap both images (desktop and mobile) and have more control over it, since you can set in the html when the images changes setting the screen size for each image.ote that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image.

  Here’s the documentation and the guide to use this tag: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

  ✌️ I hope this helps you and happy coding!

  0
• 

  htet-myet•480

  @htet-myetPosted about 2 years ago

  U did well but you forgot to put an image that they give.

  0

  ---

  

  imagine_lilies•80

  @Lilee52Posted about 2 years ago

  @htet-myet I didn’t, the image path is correct the image appears on my local pc probably because I used GitHub pages to publish, trying to rectify for hours now same issue I’ll probably use another hosting site and update here.

  0

  

  htet-myet•480

  @htet-myetPosted about 2 years ago

  @Lilee52 I though U forgot it :) . Nvm you did well.

  0