Responsive Product Preview Card

Community feedback

• 

  Francisco Carrillo•5,540

  @frank-itachiPosted over 1 year ago

  Hello there 👋. You did a good job!

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Wrap the page's whole main content in the <main> tag.
  • If your code has different sections that have a specific purpose like a navigation, article, sections or footer, it’s a good practice to enclose those parts with HTML5 landmarks. For example, you could use a <footer> tag to wrap the <div class=”attribution”> section.
  • Since the mobile design has a different image, you can use the <picture> tag that allows you to interchange the images depending of the viewport size. Red more about this awesome tag here.
  • The heading order is important in the html structure so try to always start your headings with an <h1> tag and then you can decrease by one if you need to use more heading in your html code.
  • Make sure that the <img> elements in your HTML code has an alternate (descriptive text) short text. The reason for this is that screen readers can’t translate images into text. So to fix this you can do the following <img src=”…” alt=”short text” >

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy <coding /> 😎!

  Marked as helpful

  0

  ---

  

  Furk•600

  @doganfurkanPosted over 1 year ago

  @frank-itachi Thank you for all your suggestions. Here is what I've done:

  • I added the main tag to my card, which is the main component here
  • I changed my "attribution" div to a footer just like you said
  • I changed my product header to a h1
  • I added alt attributes to my img tags

  Other than those, I've never used the picture tag you suggested. So, I'm going to have a look at your source and figure out what to do. Thanks again 🙏

  0

  

  Francisco Carrillo•5,540

  @frank-itachiPosted over 1 year ago

  @doganfurkan

  Glad to help.

  Happy <coding /> 😎!

  0