@VCarames
Posted
Hey @uchethecreator, great job on this challenge!
Some suggestions to improve you code:
- To center you content to your page, add the following to your Body Element:
body {
min-height: 100vh;
display: grid;
place-content: center ;
}
-
The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume youβre describing the image to someone.
-
This challenges requires the use of two images π for different breakpoints. The Picture Element will facilitate this.
Here is an example of how it works: EXAMPLE
Syntax:
<picture>
<source media="(min-width: )" srcset="">
<img src="" alt="">
</picture>
More Info:
https://www.w3schools.com/html/html_images_picture.asp
https://web.dev/learn/design/picture-element/
-
Increase the
padding
in the text container to better match the FEM example. -
Wrap the prices in a container and use
display: flex
along withalign-items: center
to have them perfectly aligned like the FEM example. -
The old price π· is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.
-
Implement a Mobile First approach π± > π₯
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
Happy Coding! π»π