Skip to content
Submitted 7 months ago

Responsive Product Preview Card

Arnold Limberg•410
@CreativeLogic
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I refactored this project by incorporating CSS nesting, custom properties, and a combination of flexbox and grid.

What challenges did you encounter, and how did you overcome them?

I had some difficulty getting the columns to be even with Flexbox. It's just a lot easier to accomplish this by setting a display grid and columns to 1fr, 1fr.

What specific areas of your project would you like help with?

I think I accomplished the task well. Feedback, if any, is appreciated.

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted 7 months ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have a suggestion regarding your code that I believe will be of great interest to you.

    HTML 🏷️:

    • I need to address a minor semantic improvement which may help accessibility devices to properly announce the old price of the perfume.
    • Currently the old price is not being properly announced, you have used p element for that with text-decoration: line-through css property.
    • Instead of customizing p there's actually a native semantic html element which comes handy in these situations. it is del element
    • So you can use like this <del>$169.99</del>
    • These are the tips which improves the accessibility in real world situations.
    • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    0
    Arnold Limberg•410
    @CreativeLogicPosted 7 months ago

    @0xabdulkhalid

    This is the first time I have read about this tag. All tutorials and courses I have taken have not introduced this tag. I checked MDN docs, and there seems to be accessibility concerns. Look here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/del.

    "The presence of the del element is not announced by most screen reading technology in its default configuration. It can be made to be announced by using the CSS content property, along with the ::before and ::after pseudo-elements."

    This just seems like doing extra, unnecessary work to accomplish the same task.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord