Responsive product preview card

Community feedback

• 

  Adriano•38,410

  @AdrianoEscarabotePosted about 2 years ago

  Hi Sunbear Day, how are you?

  I really liked the result of your project, but I have some tips that I think you will like:

  1- Document should have one main landmark, you could have put all the content inside the main tag click here

  2- All page content should be contained by landmarks, you can understand better by clicking here: click here

  I noticed that the content is not centered to fix this we can do the following:

  body {
      /* margin-top: 2rem; */
      /* padding: 1rem; */
      display: flex;
      align-items: center;
      justify-content: center;
      min height: 100vh;
      flex-direction: column;
  }
  

  Always prefer to center something using flex-box or grid, margin only in the latter case!

  The rest is great!!

  Hope it helps...👍

  0

  ---

  

  Sunbear Day•80

  @SunbearDayPosted about 2 years ago

  @AdrianoEscarabote Thank you for the feedback. The link to understanding landmarks was very helpful. This was my first challenge. I'm looking forward to more challenges!

  0