Skip to content
Submitted over 1 year ago

Responsive product preview card

ChrisLee•150
@ChrisLee-04-20
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

In fact, I find some problems when I style the background image of the product. The size of the image is kind of weird. Therefore, my responsive design may not be good at this moment.

If you can provide some advice on my responsive design and styling background image, I would be appreciated it.

Community feedback

  • Pipow•500
    @PipouwPieuwPosted over 1 year ago

    Hello and well done completing this challenge!

    This image is not purely decorative and is important to the page content, therefore it shouldn't be displayed as a background. I would use an <img> here, or even better a <picture>.

    This may even fix your sizing issues. :)

    Also you put a <h2> right before the <h1> which is semantically incorrect. You could wrap the word Perfume inside a <p> or maybe a <span> instead.

    Keep going, happy coding!

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord