Responsive Product Card With Flexbox

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Muhammad, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • you can use picture tag to change image by resolution -> read here
  • centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px or % use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1

  ---

  

  Muhammad Adam•210

  @Muhammad-adam778Posted almost 2 years ago

  @denielden Thank you Deniel.

  • But My browser doesn't support picture or source element do you have solution for that ?

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @Muhammad-adam778 you are welcome and keep it up :)

  How is it possible? Are you using a very old browser?

  0