Responsive product card view with html and css

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Tammy, Congratulations on completing this challenge!

  Here’s some tips to improve your solution code:

  You did a good work putting everything together in this challenge, something you can do to improve the image that needs to change between mobile and desktop is to use <picture> instead of <img> wrapped in a div. You can manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device (phone / computer) Here’s a guide about how to use picture: https://www.w3schools.com/tags/tag_picture.asp

  All you need to make the vertical alingmnet is min-height: 100vh

  body {
      min-height: 100vh;
      background: hsl(30, 38%, 92%);
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
  }
  

  ✌️ I hope this helps you and happy coding!

  1
• 

  Adriano•38,470

  @AdrianoEscarabotePosted about 2 years ago

  Hi Tammy, how are you?

  Congratulations on completing another challenge, I really liked the result of your project, but I have some tips that I think you will like:

  1- Document should have one main landmark, you could have put all the content inside the main tag click here

  2- All page content should be contained by landmarks, you can understand better by clicking here: click here

  I noticed that the content is not centered, we can fix it like this:

  body { min height: 100vh; }

  By doing this the body will fill the entire screen, and the flex-box will center the content!

  The rest is great!!

  Hope it helps...👍

  0