Design comparison
Solution retrospective
Open for all feedbacks. If you feel that I could have written the code in a different way please feel free share your opinion on it.😁
Community feedback
- @ApplePieGiraffePosted almost 2 years ago
Hi, xZAYEDx! 👋
Great effort on this challenge! 👍
I noticed that you used absolute positioning to position most of the elements in the card component. It would be worth learning a layout tool like flexbox or grid to make creating layouts with CSS much easier and way more robust. This challenge would be an excellent opportunity to use flexbox, for instance, since flexbox is great for laying out items in a row or column. If you'd like to learn more about flexbox and how to use it, this video is a nice place to start.
In addition to that, remember to write alt text for images that is descriptive and helps users understand why those images are there and what they are about. An alt text of "product" for the image in this card component isn't very descriptive. 😅
And lastly, don't forget to center the card component in the mobile view of the site, as it's sticking to the left side of the screen at the moment.
Hope you find these tips helpful. 😊
Keep coding (and happy coding, too)! 😁
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord