Responsive product card

Community feedback

• 

  Nikhil Sharma•340

  @NIk22517Posted about 2 years ago

  Hey @syrykh-feit, I'm impressed how much your first challenge is good the design is basically matching the figma files, amazing!

  Here's one tip for you:

  Improve the semantics by replacing the <div> and use <section> which is a better tag, remember that <div> doesn’t have any practical meaning is just a block of elements, so for a big block of elements use semantic tags.

  This is a good resource to understand more about semantic tags: https://www.w3schools.com/html/html5_semantic_elements.asp

  And for the <img> tag try using this

      <picture>
            <source
              srcset="mobile.jpg"
              media="(max-width: 620px)"
            />
            <img
              src="desktop.jpg"
              alt="Office Workers Smiling"
            />
          </picture>
  

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0
• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Hey @syrykh-feit, some suggestions to improve you code:

  • When using images that are different size for different breakpoints, its’ far more effective to use the <picture> element. By using this element not are able to use different size images, you can also save on bandwidth, meaning your content loads faster.

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  Source:

  https://www.w3schools.com/html/html_images_picture.asp

  https://web.dev/learn/design/picture-element/

  • There should only be one heading in this challenge and thats for the Perfume’s Name. Everything else should be using a Paragraph Element.

  • The old price isnt being announce properly to screenreaders. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.

  • The Attribution needs to be wrapped in a Footer Element.; It's the end of you content.

  • Your CSS Reset is extremely bare. You want to add more to it.

  Here are few CSS Resets that you can look at and use to create your own CSS Reset or just copy and paste one that already prebuilt.

  https://www.joshwcomeau.com/css/custom-css-reset/

  https://meyerweb.com/eric/tools/css/reset/

  http://html5doctor.com/html-5-reset-stylesheet/

  • You want to start you Media Query sooner.

  • To make you content accessible to your users, it is a best to use rem/em instead of px for your CSS property values. For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.

  More Info:

  https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9

  https://uxdesign.cc/why-designers-should-move-from-px-to-rem-and-how-to-do-that-in-figma-c0ea23e07a15

  Happy Coding!

  Marked as helpful

  0