Responsive product card

Community feedback

• 

  Oscar Bocanegra•235

  @obocanegra-devPosted over 1 year ago

  Hello @IlledNacu! 👋

  Congratulations on your fantastic work! You've done an excellent job, and I want to commend you for your efforts.

  Here are some suggestions to further improve your project:

  To vertically center the content, you could change height: 100%; to min-height: 100vh; and add justify-content: center;. This will ensure that the content is centered vertically on the viewport.

  I recommend setting a higher breakpoint value (375px is quite small) to make your design responsive on a wider range of screens. This will help ensure that your project looks great on various devices.

  Instead of setting a fixed width for the container, consider using max-width. This allows the container to be more responsive and adapt to different screen sizes.

  There's no need to fix the height of the container either. Let it adjust naturally based on its content and any specified padding or margins.

  It's important to maintain the correct order of headings. Avoid placing an <h2> before an <h1>. Make sure to follow a logical heading hierarchy to enhance readability and semantic structure.

  Font sizes should always be specified using relative units like rem or em, rather than pixels. This ensures better responsiveness and scalability across different devices.

  For decorative icons, it's not necessary to provide descriptions in the alt attribute. However, for images like the perfume, it's recommended to use more descriptive alt text to enhance accessibility.

  Everything else looks great! As an extra challenge, I invite you to experiment with transitions on the hover effect of the button. This can add a delightful touch of interactivity to your project.

  Keep up the excellent work, and don't hesitate to explore further opportunities for growth and improvement! 🚀✨

  If you have any questions or need additional assistance, feel free to ask. Enjoy the journey of your development!

  Best regards, Oscar

  Marked as helpful

  1

  ---

  

  Illed Huilen•140

  @IlledNacuPosted over 1 year ago

  @obocanegra-dev thank you, Oscar, your suggestions answer some questions I had, they're very helpful. I'll try to implement them 💪🏼✨

  1