Submitted about 1 year ago
Responsive product card component using grid and flexbox
@geektim
Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
I'll have to redo this challenge, as i did it before the learning paths feature came on board
What challenges did you encounter, and how did you overcome them?Scalability
What specific areas of your project would you like help with?Feedbacks, please!
Community feedback
- @AkshayV30Posted 8 months ago
- yes the solution is semantic HTML.
- yes it is
- It looks good
- yes, the code is well-structured, readable, and reusable
- yes a bit
1 - @stefan-holmgrenPosted 8 months ago
Looking good!
Only visual issue I saw was a white border to the left and right of the page (I have a wide monitor), and that's probably because
.container
has thebackground-color
, not thebody
.Other than that, I notice you use
px
alot. I've had people/sites/youtube tell me to steer clear of that and go withrem
, and I try to do thathttps://www.seeratawan.me/blog/why-you-should-move-from-px-to-rem-in-css/
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord