Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Not Found
Not Found
Not Found

Submitted

Responsive Product Card Component

@villAsh

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@ayobanjo

Posted

Hello @villAsh. Congratulations on your first submission.

I do have a few corrections you could apply

HTML

  1. For SEO, and proper semantics, you should use the <picture> tag. This will help you to also change from either mobile img to desktop img depending on what your approach is (mobile-first or not) picture tag

  2. The Gabrielle Essence Eau De Parfum should be an h1 element, and the perfume a paragraph

  3. For the former price, you can simply use the del tag

CSS

  1. The height of the img should be 100%, so it simply fills the available space in its container

  2. The perfume has a letter spacing, which you have omitted, try

    letter-spacing: 0.25rem, or whichever value you find desirable

  3. You can set a max-width for your main container on the desktop view.

Here is my own solution. I hope you find this helpful my submission

Marked as helpful

0

@villAsh

Posted

hello sir @ayobanjo, thank you for your kind advice.

0
Lucas 👾 104,420

@correlucas

Posted

👾Hello @villAsh, Congratulations on completing this challenge!

Your solution its almost done and I’ve some tips to help you to improve it:

Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

See the example below:

<picture>
  <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
  <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
</picture>

👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

✌️ I hope this helps you and happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord