Design comparison
Solution retrospective
Hi everyone this is my second challenge. please give your feedback to improve my self
- I felt difficulty in making the div's responsive.
- I think still there is some problem in mobile view. the whole subject is not center in the mobile view if you have the solution please let me know thank you
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
Regarding your questions:
- Here is a link to Google Developer’s site that will teach you how make your content responsive:
- To center you content to your page, add the following to your Body Element:
body { min-height: 100vh; display: grid; place-content: center; }
-
The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.
-
The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.
-
Apply
display: flex
along withalign-items: center
to the button to have the shopping cart icon and text perfectly aligned. -
Implement a Mobile First approach 📱 > 🖥
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
Marked as helpful0@vigneshajithPosted about 2 years ago@vcarames Thank you very much for your feedback. That was really Helpful. Have a nice day 😊
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord