Responsive product card

Community feedback

• 

  Andrés Gutiérrez Ramírez•2,470

  @AGutierrezRPosted 11 months ago

  Hello there @D-Salkovic 👋. Good job on completing the challenge!

  I have some suggestions about your code that might interest you.

  General Structure and HTML:

  • Wrap the primary content within the <main> tag instead of using it as a standalone component like a <div>.

  • All the content should be contained within landmarks. Every page minimally needs a <main> element.

  • Consider using <picture> tag that is commonly used for responsive images, here you can specify the difference image sources for different screen sizes and devices. For example:

    <picture>
      <source media="(min-width: 640px)" srcset="/images/image-product-desktop.jpg ">
      <img src="/images/image-product-mobile.jpg" alt="">
    </picture>
    

    Check that srcset and src are correct and change the media if you want the desktop image to kicks in on a previous or later screensize.

  CSS and Styling:

  • Instead of fixed widths, employ max-width and min-width for flexible and responsive design.
  • Let the content decide the height of the elements. Use padding and margins strategically for this purpose.
  • The body should not have its height limited. Instead of using height: 100%, use min-height: 100vh.

  Accessibility and Semantic HTML:

  • The icons/illustration images are decorative, so their alt text must be empty: alt="".

  I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!

  Happy coding!

  Marked as helpful

  1