@MelvinAguilar
Posted
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
div.product
shouldn't have a width because adiv
is a block-level element and takes up 100% width by default. Additionally, you should usemin-height: 100vh
in that selector to prevent it from becoming too short on small screens. The.page
selector has unnecessary height (min-height), as the inner div overwrites that height with100vh
.
- Use the
<footer>
tag to wrap the footer of the page instead of the<div class="attribution">
. The<footer>
element contains information about the author of the page, the copyright, and other legal information.
- The
<h1>
is the most important heading on the page, In this challenge the perfumer's name can be considered like the title of the page, so it should be the<h1>
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@EugeniaAntonova
Posted
@MelvinAguilar thank you very much!