Design comparison
Solution retrospective
This was a fun but tough challenge. I definitely tried using Grid but it really didn't want to do anything that I wanted it to do. Partially due to being unfamiliar with grid, and partially due to needing to use the same thing out of fear of new things haha.
What tips do you guys have for me regarding how to utilize grid to get the desired effect?
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
BODY MEASUREMENTS 📐:
- The
width: 100vw
property forbody
element is not necessary. because it's a block level element which will take the full width of the page by default.
- Use
min-height: 100vh
forbody
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 100vh
then thebody
will have100vh
height no matter what. Even if the content spans more than100vh
of viewport.
- But if we set
min-height: 100vh
then thebody
will start at100vh
, if the content pushes thebody
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@kelseythesimPosted over 1 year ago@0xAbdulKhalid
Thank you so much for explaining min-height vs height. I will definitely implement this more. :)
0 - @Kamlesh0007Posted over 1 year ago
Congratulations on completing the challenge! Your hard work and dedication are truly admirable. As you continue to hone your skills, here are a few suggestions that may be helpful:
Keep practicing and learning new things. The more you challenge yourself, the more you'll grow as a developer. Seek feedback from others. It's always helpful to get a fresh perspective on your work and learn from constructive criticism. Collaborate with other developers. Working with others can help you learn new techniques and improve your coding skills. Again, congratulations on completing the challenge, and I wish you continued success in your coding journey! 😁
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord