Design comparison
Solution retrospective
Any feedback would be appreciated. Thank you in advance.
Community feedback
- @cakaragiannisPosted almost 4 years ago
You've done a great job true to the original design. The animations are a nice touch. If I had to nit-pick, I'd remove the borders from the list items on the white cards, or pad them to match the padding on the darker card.
1@ashwin366Posted almost 4 years ago@cakaragiannis Thank you, I will look into it..
0 - @MasterDev333Posted almost 4 years ago
Great work! H1 tag should be only one in the page. You may change it to h2. And it would be better if you make your class names more readable. BEM naming convention is great. Please take a look if you have time. Happy coding~ :)
1@ashwin366Posted almost 4 years ago@MasterDev333 Thank you, I will surely look into it.
0 - @abhik-bPosted almost 4 years ago
Hi Ashwin ! Your solution is perfect and the flip animations are just top-notch !! Also I loved the toggle button's transitions 👌 I really loved your solution 👏👏
Keep it up 💯
1 - @santos-jadsonPosted almost 4 years ago
Hello, Ashwin! How u doing?
Your solution is great and very similar to the original one. I have nothing bad to talk about it. I mean, the only thing you could consider is to create some hover effect inside your "Learn More" button.
Congrats :D
1@ashwin366Posted almost 4 years ago@santos-jadson Hi Santos, I'm good. How are you? Thank you for the feedback, I will make the changes..
0 - @ApplePieGiraffePosted almost 4 years ago
Hey, there, Ashwin Sasikumar! 👋
Good job on another challenge! 👍 I like the unique animation you added to the circle of the toggle-switch and twisting around of the pricing cards! 🤩
I only suggest,
- Making the interactive elements of the page (such as the toggle-switch and the buttons) tabbable so that they can be accessed and used by keyboard users. Giving them a focused state would be a good idea, too, so that users can know when those elements are selected.
- Adding a hover state to the "Learn More" buttons.
Keep coding (and happy coding, too)! 😁
1@ashwin366Posted almost 4 years ago@ApplePieGiraffe Thank you for the comments, I will make the changes..
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord