matbac85• 600
@matbac85
Posted
Well done! Your component looks great.
Here are my comments (as always, I should point out that I'm a beginner, so I could be wrong):
-
Like you, I used flex, but for the .container I used grid to transform one column into two when you switch to desktop view.
-
Concerning the width of your .container: It's good to use %. If you want the width of your container to be locked at a certain size when you switch to desktop view, simply set a min-width of 90% and a max-width of 37.7rem (=600px, that's the width of the component in desktop view) and there's no need to set a max-width in your media queries.
-
You're using pixels and it's better to use em or rem. Explanations in the resources on discord.
0
