Responsive Preview Cards using FlexBox

Community feedback

• 

  Daniel 🛸•44,270

  @danielmrz-devPosted 10 months ago

  Hello @Ali-AK004!

  Your solution looks great!

  I have a couple of suggestions for improvement:

  • For semantic reasons, replace your div.container with main.container.

  This tag change has no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 10 months ago

  Hello there 👋. Good job on completing the challenge !

  I have other small suggestion about your code that might interest you.

  • Not all images should have alt text. Car icons are for decoration purposes only, so they can be hidden from screen-readers by leaving its alt attribute empty. You can read more about this here 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Ali-AK004•190

  @Ali-AK004Posted 10 months ago

  Hello @MelvinAguilar Thanks For these info , really appreciate Your Help <3

  0
• 

  raya•2,870

  @rayaattaPosted 10 months ago

  Hi Ali-ak004 congratulations completing this challenge 🎉. Here are some tips you might find useful.

  1.the main content of your page should be wrapped inside a main tag.so change <div class="container"> to <main class="container">

  2.since divs have no semantic value, change

     <div class="box green"> 
  <div class="box dark">
  

  To

  <section class="box orange">
  <Section class="box green">
  <section class="box dark">
  

  3.change <div class="btn"> to <button class="btn"> this improves navigation for people who use keys instead of the mouse. 4.since the icons are decorative their **alt ** attribute should be empty. I hope this helps with the html. Happy coding

  Marked as helpful

  1

  ---

  

  Ali-AK004•190

  @Ali-AK004Posted 10 months ago

  Hi @rayaatta Thanks A lot For These Info , Appreciate your Help <3

  1