Responsive preview card with Grid

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Hey there,

  congrats on completing the challenge successfully! Looks great. One suggestion would be to avoid using margin: 12.5em auto to place the item on the center of the page. A better practice would be using display: flex; align-items: center; justify-content: center; .In general it is better to not to hard-code any widths, heights, margins etc because it might look good on one browser size but might run into issues on other devices. Keep up the good work!

  Marked as helpful

  0

  ---

  

  Tiago Ribeiro•80

  @TiagoRidevPosted over 1 year ago

  @visualdenniss Your suggestion it was important for me, because I really had difficulty to center this container. Thanks for the feedback.

  0
• 

  Rezi Karanadze•120

  @rezis-portfolioPosted over 1 year ago

  Nice try, really good one Tiago.

  I have some tips for u :

  if u change in media query grid-templete-column to just 1fr it will fit really good, also to change img to mobile size u can use display : none and after make it block and replace.

  u can check my solution and see how I did.

  goodluck.

  0

  ---

  

  Tiago Ribeiro•80

  @TiagoRidevPosted over 1 year ago

  @rezis-portfolio thanks for the feedback.

  0