Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive Preview Card using media query

Delteuz 100

@Delteuz

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

romila 3,570

@romila2003

Posted

Hi Delteuz,

Congratulations 🎉 for completing this challenge, it was a great attempt. The card looks great and is responsive.

  1. It is good that you have used the flex property however I noticed you have used the margin property to lower the card. This is because, you have set your height to 120vh, instead change this to 100vh and it will align in the center. Also, it is good practice to use the overflow-x property and set it to hidden.
  2. For your button, you can give it a :hover property and set it to a darker shade of green which is provided in the style guide.
  3. It is good you used the main tag for your container however you should also use the footer tag for your footer e.g. <footer class="attribution"></footer>

Overall, great attempt and wish you the best for your future projects so keep coding 👍.

1

Delteuz 100

@Delteuz

Posted

@romila2003 Thanks for leaving a feedback, I appreciate it :D Sure, let me do again this challenge by following your suggestion. Stay tune to see the revised version.

1
romila 3,570

@romila2003

Posted

@Delteuz

I just took at your revised version, and it looks great.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord