romila• 3,570
@romila2003
Posted
Hi Delteuz,
Congratulations 🎉 for completing this challenge, it was a great attempt. The card looks great and is responsive.
- It is good that you have used the
flex
property however I noticed you have used themargin
property to lower the card. This is because, you have set yourheight
to120vh
, instead change this to100vh
and it will align in the center. Also, it is good practice to use theoverflow-x
property and set it tohidden
. - For your button, you can give it a
:hover
property and set it to a darker shade of green which is provided in the style guide. - It is good you used the
main
tag for your container however you should also use the footer tag for your footer e.g.<footer class="attribution"></footer>
Overall, great attempt and wish you the best for your future projects so keep coding 👍.
1