responsive preview card using flex and some js

Community feedback

• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Good job in this challenge. Viewing the solution, I think you should consider the following as well…

  • Adjust the padding in .main-content into padding: 1.5rem 3rem;, in h1 into padding-bottom: 1rem; and .main-para rule set into padding-bottom: 1rem;
  • Adjust the margin in .naming into margin-right: 14rem;
  • Instead of div, alternatively wrap the content with main tag . Use semantic tags, for HTML structures, refer it with this one Semantics
  • Include description with the alt in image tags. Like this line <img src="images/icon-share.svg" alt="">
  • Add Flexbox on max-width:952px breakpoint, with width: 80%; and height: auto; in the .container and width: 100%; in the .main-img rule set

  Above all, Well done! Keep it up and Hope this is helpful!

  Marked as helpful

  0

  ---

  

  Aviraj Walunj•80

  @avirajwalunjPosted almost 3 years ago

  @RioCantre thanks that really helps.

  0

  

  Aviraj Walunj•80

  @avirajwalunjPosted almost 3 years ago

  @RioCantre hey rio seeing your score i thinks you have been working in frontend for long time. can you tell me how can i make my code seem clearer much professional alike. i just want to improve my code, give some suggestions!

  0
• 

  optimusprime202•1,200

  @optimusprime202Posted almost 3 years ago

  Hey @avirajwalunj, This is the best ever.

  0

  ---

  

  Aviraj Walunj•80

  @avirajwalunjPosted almost 3 years ago

  @optimusprime202 thanks

  0