Responsive preview card using css flex

Community feedback

• 

  Adriano•42,780

  @AdrianoEscarabotePosted 4 months ago

  Hey mbank14, how’s it going? I was really impressed with your project’s result, though I have some advice that could be helpful:

  Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  Everything else looks great.

  Hope this helps! 👍

  Marked as helpful

  1
• 

  Andrey•2,570

  @dar-juPosted 4 months ago

  Hi mbank14! I also decided to look at your solution)

  Your work is great!

  I would like to point out several critical points:

  • If the CSS code is not several lines, then it is a good practice to separate the code into HTML and CSS files

  • The product image is not a background image. Semantically, you need to use the <picture> tag and img + alt is required. Also pay attention to other tags like <main> and <article>

  • The BEM methodology is not used quite correctly. __discount and __regular are not modifiers, etc. You can check for BEM errors using the Generator HTML tree. You can read more about BEM here.

  So, good luck in your projects!

  Marked as helpful

  1

  ---

  

  mashofa•350

  @mbank14Posted 3 months ago

  @dar-ju Thank you very much for your feedback! I really appreciate it and will make the necessary improvements based on your suggestions.

  0