@denielden
Posted
Hi Shamil, great work on this challenge! π
Here are a few tips for improve your code:
- Tip of graphic design: with
font-family:" Big Shoulders Display ", cursive
the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading)... for the designer it's a really awful font! I would rather replace it with afont-family:" Big Shoulders Display ", sans-serif
much more similar to the primary font. - remove all
margin
frommain .card
class because with flex they are superfluous - add
transition
on the element with hover effect - instead of using
px
use relative units of measurement likerem
-> read here
Overall you did well π Hope this help!
Marked as helpful
@shamilussainc
Posted
Hey @denielden , thank you for your feedback!
I have added transition to button hover. it's much better now π. I haven't noticed the font problem before. 'cursive' looks so different in Firefox from chrome. so i chooses 'sans-serif' as secondary as you said.
I have used margin for .card class to make card component suitable for mobile view. I think it's necessary for preventing component from touching screen edges. I would like to know your opinion about my approach on this.
your feedback is helpful to me. thankyouπ
@denielden
Posted
@shamilussainc In the cabinet I would have put some padding on the edges of the body ... but that's okay as you did :) happy coding!