Responsive Preview Card Component Layout

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello @youssefmagdy21, Congratulations on completing this challenge!

  Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:

  Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Youssef Magdy•160

  @youssefmagdy21Posted about 2 years ago

  Thanks for your feedback @correlucas, your suggestions are much appreciated🙏 i will make sure to keep in mind

  0
• 

  バレンタイン 😈•64,190

  @VCaramesPosted about 2 years ago

  Hey @youssefmagdy21, some suggestions to improve you code:

  • The car images/icons serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.

  Happy Coding!

  Marked as helpful

  0

  ---

  

  Youssef Magdy•160

  @youssefmagdy21Posted about 2 years ago

  Thanks for your feedback @vcarames, your suggestions are much appreciated🙏 i will make sure to keep in mind

  0