Responsive preview card built with Semantic HTML, Grid, and Flexbox.
Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey @Pound-Hash, great job on this project!
Some suggestions to improve you code:
-
Currently, as the screen size increases, your content breaks apart because it doesn't have a
max-width
on its <main> element -
For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.
-
When using buttons/links alongside the “hover” effect, you’ll run into the problem where the hover effect gets “stuck”. To prevent this, you’ll want to add the @media (hover: hover) to your CSS code and include within the query all the classes that are using the hover effect. Since not all devices support hover effects this query will then check to see if it is or not.
Happy Coding!
Marked as helpful1 -
- @correlucasPosted about 2 years ago
👾Hello @Pound-Hash, Congratulations on completing this challenge!
Your solution its almost done and I’ve some tips to help you to improve it:
I saw that you’ve used
flexbox
to place the content and create the layout.I think the best way to build this component with two columns is by using
GRID LAYOUT
since it is simpler to manage the columns and then create the media query for mobile. Here’s the steps to create it withgrid
create the main block to hold all the content (you can use<main>
to wrap), set itswidth
asmax-width: 900px
(it's the container size) anddisplay: grid
/grid-template-column: 1fr 1fr
(this means that your component will have two columns with 50% of the container width each thats 450px). To manage the column with the text use flexbox andgap
to give it the spacing between the texts or usepadding-bottom
to separate them.Then to create the mobile version, all you need to do is to change the container flow vertically with
grid-template-column: 1fr
.✌️ I hope this helps you and happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord