@edward-montoya
Posted
Nice job. I see you have implemented all the Jairo's suggestions. Now, looks better and more organized.
- I don't like the h1 divided in two pieces, probably the screen readers are smart enough to share with the user the right name. However, I prefer a "hidden" solution to separate the title from the h1 (optional).
- The modifiers of the streaming companies are defined in a wrong way. Since, you are using BEM as class naming methodology, you are using the syntax
main__item-google
, however, the correct syntax ismain__item--google
. - Instead of using
aria-hidden
in the images, I think, it is more clear if you just usealt=""
. Both options tell the screen readers that the image is decorative.
Marked as helpful
@Juanescacha
Posted
@NicolasMontoya Thank you for the feedback; I'll take a look at what you mentioned 👍