Skip to content
Submitted 7 months ago

Responsive Page with Sass and Simple Animation

Lena•230
@lenanle333
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Four card feature section
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I'm proud of being able to complete the challenge very closely to the original design all while adding a bit of my own spin to it. I also utilized the mixin feature Sass provides to create reusable cards, that way I can keep my code a lot cleaner.

What challenges did you encounter, and how did you overcome them?

At first I was having trouble getting the top border of each card to look like the original design. The border radius was all weird and wasn't aligning properly. I overcame this by adding a hidden overflow to the card itself. I also had to touch up on some grid properties because it had been awhile since I've used them. I mainly read online documentation to help me solve all of these issues.

What specific areas of your project would you like help with?

Would love any feedback. How do you feel about the animation I added to the desktop view? Is it too extra for a simple page like this?

Community feedback

  • Patricio Zarauz•140
    @PatricioZarauzPosted 4 months ago

    Congrats on completing the challenge, it's really close to the original design!!

    I've found some key areas where you can improve and simplify the code.

    • The main idea of this challenge is to use css-grid only on the cards section, so on the mobile view, you should use display: grid on the section tag.
    • You should avoid using setting the width and height to each grid item, for this you could use grid-auto-column: minmax(auto, $desired-max-width); and grid-auto-row: 1fr; where the grid is defined. By doing this, you fix the overflow issue you have on smaller desktop-views and also you guarantee that each grid item has the correct-size.
    • You could simplify your grid-template-area by doing the following:
    grid-template-area: 
". two ." 
"one two four" 
"one three four" 
". three .";

    This will make your grid template more readable, as well as you could simplify each card, by removing the grid-row property and replacing it with grid-area: one for the first card and so on.

    Other than that, the code and site look great! PS. loved the card animation on hover!!

    Marked as helpful
    1
    Lena•230
    @lenanle333Posted 3 months ago

    Thank you for the helpful feedback!! @PatricioZarauz

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord