Submitted over 3 years ago
Responsive page with mobile design first and flexbox
@victoriacheng15
Design comparison
SolutionDesign
Solution retrospective
Tried to use semantic html tags for this project. Noted: those "learn more" link, I used a tag instead of button. I probably could have use button instead. Or the link tag should be fine there?
any feedback is welcomed and appreciated. :)
Community feedback
- @grace-snowPosted over 3 years ago
Hi
Great job on this! It looks good on both portrait and landscape mobile for me ☺
Just a few very minor suggestions
- it's usually best to only have one h1 per page. I'd make all these h2s. If it was on a real site it would have a h1 above it already, but you could add one of you really wanted to
- watch the capitalisation on words like SUVs. A screenreader would read your current heading thats all lowercase as
suvs
instead ofS-U-Vs
so it's wise to keep the capitalisation - maybe increase the vertical space between the paragraph and learn more links just so it's closer to the design.
Well done again
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord