Responsive page with HTML5, CSS3 and Flexbox

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  👋Hi Daniel!

  I have some feedback on this solution:

  • The only thing that is a heading is the "10,000+ of our users love our products." sentence. For other things, you can use strong tag or other tag instead.
  • Remember, only have one h1 for every page. It's a good practice nowadays.
  • Avoid inline styling! In large project it can cause a lot of issues.
  • This should a separate element and you should not use br to make it two lines. Try to find a better solution.

  <h1>
                Colton Smith
                <br>
                <span class="verifiedbuyer">Verified Buyer</span>
              </h1>
  

  • All the person images have colton as the alternative text. The alternative text should be each person name.
  • Never use id for styling. It's not the purpose of id. Use class with BEM naming convention instead.
  • Never use magic number to specify anything. Like the height: 667px; of your container.
  • Use rem or sometimes em unit instead of px.

  That's it! Hopefully this is helpful!

  Marked as helpful

  1

  ---

  

  Daniel•60

  @danpthPosted about 3 years ago

  @vanzasetia Hey, wow, thank you! This is so detailed. Thanks for putting in your time on reviewing my code! I will be more carefull about the things you mentioned. Thank you again!

  0