Responsive page with grid(Desktop) & Flexbox(Mobile)
Design comparison
Solution retrospective
This project I am proud of using grid to make elements stay in the respective areas and stretch them to it full width and height in the container
What challenges did you encounter, and how did you overcome them?I had difficulty with aligning items of the grid in desktop layout, I have read article about grid layout which made it easy for me to align items and gave me much deeper understanding of grid layouts
What specific areas of your project would you like help with?I would like help with reducing CSS code, how can I optimize the code, I am not sure I have use correct semantic HTML, any feedback is appreciated, Thanks
Community feedback
- @huyphan2210Posted 16 days ago
Hi, @VSKarthikT
I checked out your solution and I have some thoughts:
HTML Suggestions:
- For your
.wrapper_[number]
elements, consider using thearticle
tag instead ofdiv
, as it gives more semantic meaning when wrapping content that feels article-like. - The
.w_content[number]
elements inside.wrapper_[number]
might be redundant. You could apply the.w_content
styles directly to their parent.wrapper_[number]
and remove the extra elements for a cleaner structure. - For
title[number]
, which seems to be each article’s heading, try usingh1
instead ofp
tags. Anh1
establishes a clear heading hierarchy, especially useful for accessibility and SEO.
CSS Suggestions:
- Many of your classes, like
.title1
,.title2
,.title3
, etc., have identical styles. You can simplify this by grouping them. For example:
.title { font-weight: $CT_font-weight-title; font-size: $CT_font-sz-title; letter-spacing: 0; }
- Try using
min-height: 100dvh
instead ofheight: 100dvh
onbody
to prevent layout issues on mobile when the address bar shifts. width: 100%
isn’t necessary forsection
or block-level elements as they already span the full width by default. You can remove it to simplify the code.
Hope this helps!
Marked as helpful1 - For your
- @herojk64Posted 16 days ago
Ok, if you want to reduce CSS the very first concept is to make as minimal html as possible. if you see your html there are few things I saw. why aren't you dividing your sections with section tag rather than div. you are just using section as main component which is nested in the main. I also don't see any header tag or h1,h2,etc. you see with the content you can separate the headers based on the title looking content. also article tags are best for that if you want to do better SEO. Anyway mixin in SCSS was a great find for me took me seconds to understand but didn't knew it was a thing in SCSS so thanks for that.
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord