Responsive page with flexbox

Community feedback

• 

  P

  Ken•4,915

  @kens-visualsPosted about 3 years ago

  Hey @fvaldes0109 👋🏻

  I just have a small suggestion for the project.

  • The social links, could be in ul and each li could have <a> tag that can either take to empty pages of the websites accordingly or just point to nowhere href="#". This would be semantically correct.
  • The icons should have aria-hidden="true" and if you choose to implement my suggestion, make sure to add aria-label for the <a> tags that would have the names of the icons, such as, aria-label="facebook" and like so for the other two icons.

  I hope this was helpful 👨🏻‍💻 other than that, you did an excellent job, nicely done. Cheers 👾

  Marked as helpful

  2
• 

  Benjo Quilario•1,810

  @benjoquilarioPosted about 3 years ago

  Hello Fernando 👋

  Everything looks good and I like you solution. Much better than me when I did this challenge😅.

  My only small suggestion is:

  • Instead of using <div> elements to wrapping your svg logos you should use anchor element <a> because this element is going to transfer user somewhere.

  Keep coding and happy coding too!

  Marked as helpful

  1