responsive page with flex layout

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace <div class="cardArea"> with the main tag, <div class="p2"> with <p> and <div class="p1"> with <h1> to make the content/page accessible. click here for more on web-accessibility and semantic html

  Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  To center .card on the page using flexbox, replace the height in .cardArea with min-height: 100vh.

  For a responsive content,

  • Replace the width in .card with max-width and the height witha padding value for all the sides padding:16px which is 1rem/em
  • Give the img a max-width of 100% and a border-radius value, the rest are not needed.

  Give h1 and p text-align: center, the same margin-left, margin-right and margin-top values. Give p a margin bottom value a font-size of 15px which is 0.9375rem,.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1

  ---

  

  Guo Xusheng•90

  @mvpshengPosted over 1 year ago

  @Hassiai 😄Thanks, This helps me a lot.

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  QR iMAGE ALT TEXT 📸:

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute.

  ---

  • The alt attribute should explain the purpose of the image.

  ---

  • E.g. alt="QR code to frontendmentor.io"

  ---

  <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Guo Xusheng•90

  @mvpshengPosted over 1 year ago

  @0xAbdulKhalid Thanks, it is interesting.😄

  0