Responsive Page using semantic elements in HTML5, SCSS and ES6

Community feedback

• 

  Nguyen Nguyen•340

  @jesuisbienbienPosted over 2 years ago

  Hi Zayed,

  Congrats on completing this challenge. Though, I believe there're a few things you need to fix:

  • There's something wrong with the submit button and the illustration. On desktop, the illustration is underneath the submit button, and vice versa for the mobile view. They should be a few rem apart instead of lying on top of e/o.

  • When you submit a blank input, the error message is supposed to say "Whoops! It looks like you forgot to add your email". You can find the instruction under the README.md file.

  • When I submitted an incomplete email (i.e. mail@mail ), it's supposed to be error but it turns blue instead.

  • The submit button should have a box-shadow.

  If you have any questions, let me know. I also completed this challenge recently. You can check it out under my profile.

  Happy coding :D

  Marked as helpful

  0
• 

  Qstar12•70

  @Qstar12Posted over 2 years ago

  Great job!

  1

  ---

  

  xZAYEDx•250

  @xZAYEDxPosted over 2 years ago

  @Qstar12 thanks bro!

  0