Responsive Page using Sass - with mix of Flexbox and Grid

Community feedback

• 

  T

  Grace•31,230

  @grace-snowPosted over 3 years ago

  Hi

  This looks really good, well done.

  Let's talk about html though ☺

  It's really important for

  • the most appropriate semantic elements to be used
  • headings to go in order

  That leaves 2 issues with this html structure in tour solution.

  1. H4 is a very low heading level to start with on this content. I know in a _real: website this probably wouldn't be the only contents of a page. There would be a header, navigation, footer etc and probably a h1 already, if this was on a real site. Therefore, the headings in this solution would need start at h2; Or maybe h3 (if the testimonials were a section on a longer page they would probably have a h2 above them saying "Testimonials"). I would use h3.

  2. Should your current h2s be headings? Would they make sense if listed on a contents page? Are they short enough to be a heading? Do they make sense as headings for the content dierectly below them? If the answer is no to any of these questions, they shouldn't be headings. They are just paragraphs with a different style treatment.

  I hope this helps you. I've tried to go through the thinking process behind each decision for you.

  Frontend developers need to nail this stuff that is all about interpreting design and translating into its component parts ☺

  Marked as helpful

  0