Design comparison
Community feedback
- @5hraddhaPosted almost 3 years ago
Hey @leodsc, Awesome job at implementing the design. I really like how you have used different React features together.
There a few suggestions for improvement that means nothing is wrong but in case, you wish to level up and polish your solution.
-
Ensure headings are in a logical order. For example, check that all headings are marked with h1 through h6 elements and that these are ordered hierarchically. For example, the heading level following an h1 element should be an h2 element, not an h3 element.
-
You could use the JS object destructuring syntax to get values from props in a component. Nothing big, but it makes code more clean and you get to use new features of the language. Here, is a link of an awesome article on the same - Object Destructuring in JS
I too learnt few things while going over your code. Thank you and have a great day!!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord