Responsive page using position and flexbox

Community feedback

• 

  filecc•470

  @fileccPosted over 1 year ago

  🌈 Hi and congratulations for completing a new challenge on Frontend Mentor!

  I take a look at your code, here's something you could fix, if you want:

  1. HTML heading should always increase one by one, on line 22 in your HTML file you use, correctly an H1, but after that on your line 35 you use an H4, instead you should write <h2>Rated 5 Stars in Reviews</h2>. If you need to decrease the size of the text, consider to target the <h2>elements in your CSS and writing something like h2 { font-size: 'some size of your choice'};
  2. You had write your path to the images with a backslash \, avoid doing this, use a pattern like this instead ```<img class="estrela" src="./images/icon-star.svg" alt="">````. It's more safe and it's correctly typed.
  3. Your <section> that start at line 60 lack of a heading. Consider put a hidden <h2>element that can described the section content, without being actually displayed.

  Hoperyou'll find this helpful 👍 and happy coding! 🥰😁

  Marked as helpful

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by wrapping the whole content with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  • And, this solution had also generated accessibility error report due to skipping heading levels

  ---

  • We want to avoid skipping heading levels, make sure to start with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that our document has a clear and consistent hierarchy. Read more 📚

  ---

  • Because skipping heading levels is a poor practice from the perspective of information design, whether we are talking about web pages, books, journal articles, or about anything else. You can not only confuse screen readers but all readers when you don't follow a consistent, logical pattern with your heading structure.

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0