Responsive Page using media query, flex box, margin, border-radius .

Community feedback

• 

  raya•2,870

  @rayaattaPosted 10 months ago

  Hello Orimoloye Oluwanifemi👋, congratulations on completing your first FED challenge 🎉

  I have some suggestions you might find useful.

  1 Try to make your html more Semantic by wrapping the main page content inside a <main> tag . Replace <div class="container"> With <main class="container">. This changes nothing visually but Using it makes all the difference. Using semantic markup improves

  SEO

  And user experience (accessibility) for people using assistive technology such as screen readers.

  2 I noticed that you used h3 .since it is the only heading in the document you should replace it with <h1>.

  Here's a quick guide on how to use them:

  The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on. You can then style them in you css.

  Unlike what most people think, it's not just about the size and weight of the text It is about maintaining a clear and consistent hierarchy through out the document

  3

  The qr code's alt attribute should have text stating what is and where it leads i.e alt="qr code leading to frontendmentor.io

  I hope this helps 🙃 Your solution looks awesome Happy coding ✌️

  0

  ---

  

  Orimoloye Oluwanifemi•10

  @Oluwanife441Posted 10 months ago

  @rayaatta ohhh I see thanks so much, will make the adjustments now.

  1
• 

  Sakti•190

  @saktiajadehPosted 10 months ago

  Hi @Oluwanife441, the results of the solution you made in this challenge are quite good, but the image doesn't appear. You can adjust the src attribute of the image tag to be like this

  <img src="./images/image-qr-code.png" width="300px" height="300px">
  

  Awesome work and Happy Coding

  0

  ---

  

  Orimoloye Oluwanifemi•10

  @Oluwanife441Posted 10 months ago

  @saktiajadeh I just noticed that . Why is my image not displaying?

  0